Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and replace with substring in markdown and raw cells #16293

Merged

Conversation

JasonWeill
Copy link
Contributor

@JasonWeill JasonWeill commented May 6, 2024

Fixes #16292.

Adapts the codemirror searchprovider changes from #15881 to also apply to the MarkdownCellSearchProvider. Updates unit tests to test all pairs of code, markdown, and raw cells.

@JasonWeill JasonWeill added the bug label May 6, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@JasonWeill JasonWeill changed the title WIP: Search and replace with substring in markdown and raw tests Search and replace with substring in markdown and raw cells May 6, 2024
@JasonWeill JasonWeill marked this pull request as ready for review May 6, 2024 22:28
@srdas
Copy link

srdas commented May 6, 2024

@JasonWeill - I installed, built, and tested the new version from your branch search-replace-substring-markdown and the find and replace is now working as expected across all types of cells (code, markdown, raw).

@JasonWeill JasonWeill merged commit 393d80f into jupyterlab:main May 7, 2024
82 of 83 checks passed
@jtpio jtpio added this to the 4.2.x milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In markdown cells, replacing a string with text that contains the string fails
3 participants