Wait for the cell toolbar items to be rendered the first time before looking for overlap #16291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cell toolbar is attached the first time, the items may not be rendered when we try to see if it overlap the cell content.
This make the toolbar to be displayed when it should not (see #15305 (comment))
References
Related to #15305, and more specifically should fix #15305 (comment)
Code changes
requestIdleCallback()
instead ofrequestAnimationFrame()
before looking for overlap (this should wait for changes in the cell and in the toolbar to be effective).User-facing changes
Avoid the toolbar to be displayed when it should not.
Backwards-incompatible changes
None