Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs in notebook section #16284

Closed
wants to merge 4 commits into from

Conversation

Gecervantes01
Copy link

@Gecervantes01 Gecervantes01 commented May 5, 2024

Updated the cell collapsing docs

References

The updated docs are in reference to issue #16179

Code changes

The previous documentation on cell collapsing was as follows:
“Collapse and expand code and output using the View menu or the blue
collapser button on left of each cell:”

The suggested updated docs:
“Collapse and expand code and output using the View menu or the blue
collapser button on left of each cell. While collapsed, only the first
line of the cell is displayed:”

This addition at the end provides a clear indication of what is to be expected visually when collapsing a cell.

User-facing changes

Before:
Before

After:
After

Backwards-incompatible changes

There are no backwards-incompatible changes.

Added to the cell collapsing docs, as specified in issue #16197
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link

welcome bot commented May 5, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Gecervantes01 Gecervantes01 changed the title Updated docs to include Updated docs in notebook section May 5, 2024
@Gecervantes01
Copy link
Author

Gecervantes01 commented May 6, 2024

Bot please update snapshots

Copy link
Contributor

github-actions bot commented May 6, 2024

Documentation snapshots updated.

Copy link
Contributor

github-actions bot commented May 6, 2024

Galata snapshots updated.

@@ -82,7 +82,8 @@ Create multiple synchronized views of a single notebook:
.. _collapse-code:

Collapse and expand code and output using the View menu or the blue
collapser button on left of each cell:
collapser button on left of each cell. While collapsed, only the
first line of the cell is displayed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video below is well outdated and does not actually show this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a flaky update and should be reverted. In general, this PR did not change snapshots so far so there is no need to update them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted. #15305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants