New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changing font size in text editor #16261
Fix changing font size in text editor #16261
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FoSuCloud
I spotted a small glitch that the gutter line number is not updated right away when changing the font size; example when increasing the font size
CodeMirror does update the font size of the gutter if I switch back and forth to the file editor. I guess forcing an update after updating the font size may smooth the user experience.
@@ -103,4 +103,42 @@ ut elit.` | |||
const tabHandle = await page.activity.getPanelLocator(DEFAULT_NAME); | |||
expect(await tabHandle?.screenshot()).toMatchSnapshot(imageName); | |||
}); | |||
|
|||
test.describe('Changing a text editor font-size', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding a test for this ❤️
Thanks for knowing the problem, I will force update the number of lines after updating the font size |
It seems that the "should Decrease Content Font Size" and "should Increase Content Font Size" test cases failing have nothing to do with the pr here |
@meeseeksdev please backport to 4.1.x |
Co-authored-by: FoSuCloud <49218295+FoSuCloud@users.noreply.github.com>
References
Fixes: #16182
Code changes
packages/fileeditor-extension/src/commands.ts
User-facing changes
no
Backwards-incompatible changes
no