Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing search and replace with cell outputs #16260

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BrunoNeira-cmu
Copy link

References

Builds from #16157
Resolves #15966

Code changes

  • updated highlighting logic in genericsearchprovider.ts to support highlighting in cell outputs
  • updated searchmodel.ts to support disabling replace button when current match is in cell output

User-facing changes

  • highlights search matches even if matches are in cell outputs
  • disables the replace button when the current match is in the cell output.

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link

welcome bot commented Apr 28, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@BrunoNeira-cmu
Copy link
Author

Currently draft PR because I'm working on disabling the Replace All button when all matches in are in cell outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable "Search Cell Outputs" in Find/Replace, disable "Replace" button when an output is highlighted
2 participants