Add an option to continue indentation, upgrade @codemirror/commands
#16252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #16196
Code changes
@codemirror/commands
User-facing changes
New continue indentation option:
TBD, as the current behaviour of
insertNewlineKeepIndent
turned out to be different from what I thought it would do, see codemirror/dev#1370 (comment).Depending on whether upstream (CodeMirror) reconsiders, we may need to do something different, for example always run
insertNewlineAndIndent
while comparing the indentation before and after and if it decreased at the end of the block we would re-add the indentation. Or maybe we need to vendor a modified copy ofinsertNewlineAndIndent
which does not dedent at the end of the block (not sure if this is feasible). Or maybe we need to modify the Python language implementation only in which case this PR would be of little use in the current state.Backwards-incompatible changes
None