Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing translation wrapper in debugger filter box #16224

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Add missing translation wrapper in debugger filter box #16224

merged 6 commits into from
Apr 25, 2024

Conversation

itsmevichu
Copy link
Contributor

Fix for #16220

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski added the bug label Apr 22, 2024
@krassowski krassowski added this to the 4.2.0 milestone Apr 22, 2024
krassowski
krassowski reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see a small suggestion on passing the trans instead of the translator object - this should also reduce the changeset.

Looks good otherwise:

Screenshot from 2024-04-25 11-57-35

packages/debugger/src/panels/kernelSources/filter.tsx Outdated Show resolved Hide resolved
krassowski
krassowski approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @itsmevichu!

@krassowski krassowski changed the title Missing translation wrapper debugger filter box Add missing translation wrapper in debugger filter box Apr 25, 2024
@krassowski krassowski merged commit a067078 into jupyterlab:main Apr 25, 2024
80 of 82 checks passed
gderocher pushed a commit to gderocher/jupyterlab that referenced this pull request Apr 26, 2024
@itsmevichu @krassowski @gderocher
Add missing translation wrapper in debugger filter box (jupyterlab#16224
ab082fc 
)

* Added the missing translation wrapper

* Added the missing translation wrapper

* Adapting few minor changes

* Update docstring

---------

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@fcollonval fcollonval mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@itsmevichu itsmevichu

Labels
bug pkg:debugger
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsmevichu @krassowski