Enable full notebook windowing mode by default
#15964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
Linking to jupyter/notebook#7231 as something we will likely want to fix if this becomes the default. Unless Notebook still defaults to |
|
Thanks, I added jupyter/notebook#7231 to the list in #15258. Looking at visual regression CI failures, something to consider is whether we want to pin some tests to use |
This one was taking snapshots of the entire main area; I think we should not do that. Especially because it is supposed to test if galata is working, not jupyterlab UI itself. |
it does not make much sense, especially for cells; instead, capture the notebook itself. Add a new test for saving, because that was implicitly tested by `Run Cells` test (and is not anymore). Of note, one of the tests, `Open and run cell by cell` is still taking a snapshot of the entire panel; this is intentional - we do want one snapshot to be more encompassing (but not all of them!).
|
bot please update snapshots |
as the toolbar is irrelevant for the snapshot of headings!
The rest of the UI does not really matter on these snapshots and it only makes the content small and hard to read in the docs.
krassowski
force-pushed
the
enable-full-windowing-mode
branch
from
feb6775
to
a7f363f
Compare
|
Documentation snapshots updated. |
|
Galata snapshots updated. |
|
@gabalafou I hope the trimming of snapshots in this PR will make you happy :) |
krassowski
force-pushed
the
enable-full-windowing-mode
branch
from
b48ea42
to
e55c83c
Compare
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
* Enable `full` windowing mode by default * Use `none` mode for mermaid snapshots tests * Account for the windowed scrollbar button * Do not capture the full main area in galata notebook tests it does not make much sense, especially for cells; instead, capture the notebook itself. Add a new test for saving, because that was implicitly tested by `Run Cells` test (and is not anymore). Of note, one of the tests, `Open and run cell by cell` is still taking a snapshot of the entire panel; this is intentional - we do want one snapshot to be more encompassing (but not all of them!). * Update the debugger button sizing * Only capture notebook content in custom CSS test of headings as the toolbar is irrelevant for the snapshot of headings! * Only capture the main area for altair and html docs snapshots The rest of the UI does not really matter on these snapshots and it only makes the content small and hard to read in the docs. * Update Playwright Snapshots * Update Playwright Snapshots * Fix toolbar test (account for the scrollbar button) * Revert spurious snapshot updates * Fix missing dot in selector * Use `none` for collapsible headings test * Add notebook-tab-saved snapshot * Fix misplaced config --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
Enables
fullnotebook windowing mode by default to gather wider user feedback during JupyterLab 4.2.0 pre-release testing. If we do not get far enough with tackling issues from #15258 before 4.2.0 we can revert this PR.User-facing changes
JupyterLab works faster when long notebooks are open.
Backwards-incompatible changes
None