Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Playwright 1.43.1 #15621

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Update to Playwright 1.43.1 #15621

merged 11 commits into from
Apr 30, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 9, 2024 •
edited

References

Maintenance task to update to the latest stable version of Playwright.

The latest versions have introduced some useful features.

Code changes

  • Update @playwright/test dependency
  • Update reference snapshots

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.1.0 milestone Jan 9, 2024
@krassowski krassowski modified the milestones: 4.1.0, 4.2.0 Jan 17, 2024
@jtpio jtpio changed the title Update to Playwright 1.40.1 Update to Playwright 1.42.1 Mar 20, 2024
jtpio
jtpio commented Mar 20, 2024
View reviewed changes
galata/tsconfig.json
@@ -6,7 +6,7 @@
"rootDir": "src",
"module": "commonjs",
"types": ["node"],
"lib": ["DOM", "DOM.iterable", "es2019.array"]
"lib": ["DOM", "DOM.iterable", "es2019.array", "esnext"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be needed according to microsoft/playwright#28262

@jtpio
Copy link
Member Author

jtpio commented Mar 21, 2024

bot please update snapshots

@github-actions GitHub Actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions GitHub Actions
Copy link
Contributor

Galata snapshots updated.

@jtpio
Copy link
Member Author

jtpio commented Mar 21, 2024

bot please update snapshots

@github-actions GitHub Actions
Copy link
Contributor

Documentation snapshots updated.

@jtpio jtpio closed this Mar 21, 2024
@jtpio jtpio reopened this Mar 21, 2024
@fcollonval
Copy link
Member

@jtpio can I take this one over? It is part of #15916 but I would rather split the changes in multiple PRs?

@jtpio
Copy link
Member Author

jtpio commented Apr 9, 2024

It is part of #15916

By "it is part" you mean #15916 is also updating the Playwright version?

Otherwise yes feel free to take over and push to the branch directly. If I remember correctly it still needed some work w.r.t updating the snapshots.

Also updating Playwright in a separate PR (like this one) sounds good, so we have a better idea of what had to change with the update.

@fcollonval
Copy link
Member

By "it is part" you mean #15916 is also updating the Playwright version?

Yes an updated playwright version is required to access a new type of reporter to allow merging of reports when sharding the tests.

@fcollonval fcollonval changed the title Update to Playwright 1.42.1 Update to Playwright 1.43.0 Apr 11, 2024
@fcollonval fcollonval force-pushed the update-playwright branch 2 times, most recently from 43a3ea3 to 840fc86 Compare April 12, 2024 12:02
@fcollonval
Copy link
Member

bot please update snapshots

@github-actions GitHub Actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions GitHub Actions
Copy link
Contributor

Galata snapshots updated.

@jtpio jtpio closed this Apr 15, 2024
@jtpio jtpio reopened this Apr 15, 2024
@fcollonval
Copy link
Member

bot please update snapshots

@github-actions GitHub Actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions GitHub Actions
Copy link
Contributor

Galata snapshots updated.

@fcollonval fcollonval marked this pull request as ready for review April 30, 2024 06:57
@fcollonval fcollonval changed the title Update to Playwright 1.43.0 Update to Playwright 1.43.1 Apr 30, 2024
jtpio
jtpio commented Apr 30, 2024
View reviewed changes
galata/test/galata/fixture.spec.ts
expect(tmpPath).toEqual(
'test-galata-fixture-tmpPath-should-return-an-unique-test-folder-galata'
expect(tmpPath).toMatch(
/test-galata-fixture-tmpPat-\w{5}-eturn-an-unique-test-folder-galata/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a quick comment to remember why we need this regex? Probably because the text is truncated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added in 2fdea68

@jtpio
Copy link
Member Author

jtpio commented Apr 30, 2024

Thanks @fcollonval!

Left a minor comment, otherwise looks good! We can probably move forward with this to unblock other PRs.

@fcollonval fcollonval self-requested a review April 30, 2024 15:08
fcollonval
fcollonval approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @jtpio

@fcollonval fcollonval merged commit caa728b into jupyterlab:main Apr 30, 2024
81 checks passed
@jtpio jtpio deleted the update-playwright branch April 30, 2024 16:07
@jtpio jtpio mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@jtpio jtpio

Labels
maintenance tag:Testing
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtpio @fcollonval @krassowski