Make the DOM structure of linked output views more similar to outputs #14911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
SylvainCorlay
force-pushed
the
linked-output-view
branch
from
ee0a540
to
0afc3c5
Compare
SylvainCorlay
force-pushed
the
linked-output-view
branch
from
c232223
to
dc93f31
Compare
|
Ping @krassowski. In this PR, I am just making the linked view of the output be more like the actual output in terms of DOM structure, which is probably better regardless of other questions. I will open a PR on fixing the firefox issue after this one. |
krassowski
approved these changes
Aug 8, 2023
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 9, 2023
… views more similar to outputs
jtpio
pushed a commit
that referenced
this pull request
Aug 9, 2023
…e similar to outputs (#14941) Co-authored-by: Sylvain Corlay <sylvain.corlay@gmail.com>
|
Thanks, I will fix the scrolling issue now. |
This was referenced Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #14564 by giving the linked output view the same DOM structure as the normal output (except for prompts).