-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab/NB7 extension compatibility docs #14838
Lab/NB7 extension compatibility docs #14838
Conversation
Thanks for making a pull request to jupyterlab! |
…yterlab into dual_compat_extensions
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
for more information, see https://pre-commit.ci
…yterlab into dual_compat_extensions
for more information, see https://pre-commit.ci
…yterlab into dual_compat_extensions
for more information, see https://pre-commit.ci
I pushed some edits/refactors as discussed above, and verified that the code snippets are up to date with the current version of the examples repo. Waiting for CI now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Some small suggestions before we merge it
using instructions from `the extension tutorial <https://jupyterlab.readthedocs.io/en/latest/extension/extension_tutorial.html>`_). | ||
Once your template is ready, you can start adding components and features to build your extension. | ||
|
||
An extension for JupyterLab (and for Notebook 7) is made up of a `series <https://jupyterlab.readthedocs.io/en/latest/extension/extension_dev.html>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use sphinx reference, not a fully specified link
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
I changed the title, and made another PR for some of the extra suggestions. Waiting for CI build to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds a new extension-compatibility document to the documentation. Some sample code will also be committed to the examples repo, related PRs:
Step counter (provider-consumer example in 3 related packages)moved to Add dedicated plugin system document #15417