Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab/NB7 extension compatibility docs #14838

Merged
merged 69 commits into from
Mar 5, 2024

Conversation

ericsnekbytes
Copy link
Contributor

@ericsnekbytes ericsnekbytes commented Jul 17, 2023

Adds a new extension-compatibility document to the documentation. Some sample code will also be committed to the examples repo, related PRs:

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@ericsnekbytes
Copy link
Contributor Author

I pushed some edits/refactors as discussed above, and verified that the code snippets are up to date with the current version of the examples repo. Waiting for CI now.

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some small suggestions before we merge it

docs/source/extension/extension_dev.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
using instructions from `the extension tutorial <https://jupyterlab.readthedocs.io/en/latest/extension/extension_tutorial.html>`_).
Once your template is ready, you can start adding components and features to build your extension.

An extension for JupyterLab (and for Notebook 7) is made up of a `series <https://jupyterlab.readthedocs.io/en/latest/extension/extension_dev.html>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use sphinx reference, not a fully specified link

docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
docs/source/extension/extension_multiple_ui.rst Outdated Show resolved Hide resolved
ericsnekbytes and others added 3 commits January 23, 2024 12:54
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@ericsnekbytes
Copy link
Contributor Author

ericsnekbytes commented Feb 23, 2024

I changed the title, and made another PR for some of the extra suggestions. Waiting for CI build to review.

@krassowski
Copy link
Member

There is a failure in the docs test, could you take a look?

image

@ericsnekbytes
Copy link
Contributor Author

There is a failure in the docs test, could you take a look?

image

Resolved 👍

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit afeb955 into jupyterlab:main Mar 5, 2024
78 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants