Revert target to ES2017 #13914
Merged
Revert target to ES2017 #13914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add migration note
|
Thanks for making a pull request to jupyterlab! |
jasongrout
reviewed
Feb 3, 2023
jasongrout
reviewed
Feb 3, 2023
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #13913
Code changes
Revert TypeScript target to "ES2017" and add a migration note.
User-facing changes
None
Backwards-incompatible changes
None - the emitted type will still include
AsyncIterableand require downstream consumer to either add it to TypeScript lib or bump their target to ES2018.