Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict CSS containment for MainAreaWidget #13811

Merged

Conversation

krassowski
Copy link
Member

References

Relates to jupyterlab/lumino#504. Supersedes #13672.

This is a smaller version of jupyterlab/lumino#506 which I hope can be backported and included in 3.x.

This PR is not needed on 4.x once jupyterlab/lumino#506 is merged and released.

Code changes

Addition of:

.jp-MainAreaWidget {
  contain: strict;
}

User-facing changes

  • Notebook outputs producing html elements with transform: translate* styles will not be drawn outside of the notebook boundaries.
  • Substantial performance boost (reduction in layout cost) on Chromium browsers

Backwards-incompatible changes

As above.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@fcollonval fcollonval merged commit 4440f15 into jupyterlab:3.6.x Jan 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Design System CSS enhancement pkg:apputils tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants