Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates jupyter_ydoc #13735

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Updates jupyter_ydoc #13735

merged 1 commit into from
Jan 9, 2023

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Jan 9, 2023

There is a minor issue with the latest alpha published. The dependency @jupyter/ydoc is a singleton package whose version should match the version used by an extension. The problem is that JupyterLab pins @jupyter/ydoc v0.2.0 but uses 0.2.2 when loading an extension that uses @jupyter/ydoc. It fails, saying the dependency is not in the shared context.

References

Code changes

Pins @jupyter/ydoc v0.2.2.

User-facing changes

Backwards-incompatible changes

@hbcarlos hbcarlos added the bug label Jan 9, 2023
@hbcarlos hbcarlos self-assigned this Jan 9, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 4.0.0 milestone Jan 9, 2023
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit dc55aca into master Jan 9, 2023
@hbcarlos hbcarlos deleted the update_ydoc branch January 9, 2023 11:43
@jtpio
Copy link
Member

jtpio commented Jan 9, 2023

It fails, saying the dependency is not in the shared context.

Does it fail, or is it a warning in the dev tools console?

@jtpio
Copy link
Member

jtpio commented Jan 9, 2023

Normally the shared packages should be quite permissive for now, and not using strictVersion as experimented in #9500.

@hbcarlos
Copy link
Member Author

hbcarlos commented Jan 9, 2023

Does it fail, or is it a warning in the dev tools console?

It fails and doesn't load the extension.

@jtpio
Copy link
Member

jtpio commented Jan 9, 2023

Would you mind posting the logs / error for reference?

It can also be useful later if someone encounters something similar.

@hbcarlos
Copy link
Member Author

This is the error from the dev console:

Error: Shared module @jupyter/ydoc doesn't exist in shared scope default
    at d (remoteEntry.0706a6342d7099beee77.js:1:7419)
    at remoteEntry.0706a6342d7099beee77.js:1:8547
    at remoteEntry.0706a6342d7099beee77.js:1:8411
    at 4059 (remoteEntry.0706a6342d7099beee77.js:1:9335)
    at remoteEntry.0706a6342d7099beee77.js:1:11033
    at Array.forEach (<anonymous>)
    at _.f.consumes (remoteEntry.0706a6342d7099beee77.js:1:10863)
    at remoteEntry.0706a6342d7099beee77.js:1:1631
    at Array.reduce (<anonymous>)
    at _.e (remoteEntry.0706a6342d7099beee77.js:1:1609)

@jtpio
Copy link
Member

jtpio commented Jan 10, 2023

Hmm, maybe it could be related to the rename to @jupyter/ydoc? #13506

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants