-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates jupyter_ydoc #13735
Updates jupyter_ydoc #13735
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hbcarlos
Does it fail, or is it a warning in the dev tools console? |
Normally the shared packages should be quite permissive for now, and not using |
It fails and doesn't load the extension. |
Would you mind posting the logs / error for reference? It can also be useful later if someone encounters something similar. |
This is the error from the dev console:
|
Hmm, maybe it could be related to the rename to |
There is a minor issue with the latest alpha published. The dependency
@jupyter/ydoc
is a singleton package whose version should match the version used by an extension. The problem is that JupyterLab pins@jupyter/ydoc
v0.2.0 but uses 0.2.2 when loading an extension that uses@jupyter/ydoc
. It fails, saying the dependency is not in the shared context.References
Code changes
Pins
@jupyter/ydoc
v0.2.2.User-facing changes
Backwards-incompatible changes