default locale will use OS default locale

[fcollonval]

References

Fix #9672

Code changes

New default value for language settings to use the default locale (if the associated language pack is installed).

Requires jupyterlab/jupyterlab_server#366

User-facing changes

JupyterLab loads with the OS language by default (if the associated language pack is installed)

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[fcollonval]

@krassowski would you mind testing this one?

I tested locally on a laptop with French as default Windows language. But I would appreciate if some non-english user can test it too.

[krassowski]

Tested locally, works well - thanks!

I left a minor suggestion to add a comment in one place.

[krassowski]

The use of empty string looks odd. Might benefit from a commit explaining it.

[fcollonval]

Thanks for the review and test @krassowski

[krassowski]

I wonder if we should use Navigator.languages instead. I can imagine a classroom where instructor's native language is very different from language the students use. In RTC mode, this would lead to everyone being served an interface they cannot navigate. Maybe the order of preference should be:

• browser language from Navigator.languages,
• default from server
• English

Feel free to move the discussion to a new issue if you want to go ahead merging it as-is.

[fcollonval]

I'm gonna backport it as jupyterlab_server has been released (and it does not break API).

[fcollonval]

@meeseeksdev please backport to 3.6.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 3.6.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 5caeba5fb5dae5b46c19fdb7def17cc8979abef1

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #13721: `default` locale will use OS default locale'

4. Push to a named branch:

git push YOURFORK 3.6.x:auto-backport-of-pr-13721-on-3.6.x

5. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13721 on branch 3.6.x (default locale will use OS default locale)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.