-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not needed Completer.IRenderer.sanitizer
#13700
Remove not needed Completer.IRenderer.sanitizer
#13700
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@meeseeksdev please backport to 3.6.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
References
Link to #13663
It removes a not-needed attribute from the interface
Completer.IRenderer
introduced in #13341 (not yet release if this is backported to 3.6.0).Code changes
Remove not needed
Completer.IRenderer.sanitizer
User-facing changes
None
Backwards-incompatible changes
None if backported before releasing 3.6.0