Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed Completer.IRenderer.sanitizer #13700

Conversation

fcollonval
Copy link
Member

References

Link to #13663
It removes a not-needed attribute from the interface Completer.IRenderer introduced in #13341 (not yet release if this is backported to 3.6.0).

Code changes

Remove not needed Completer.IRenderer.sanitizer

User-facing changes

None

Backwards-incompatible changes

None if backported before releasing 3.6.0

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added api-change A change that should be accompanied by a major version increase enhancement labels Jan 3, 2023
@fcollonval fcollonval added this to the 3.6.0 milestone Jan 3, 2023
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcollonval fcollonval merged commit da6c658 into jupyterlab:master Jan 4, 2023
@fcollonval fcollonval deleted the ft/remove-completer-IRenderer-sanitizer branch January 4, 2023 10:40
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 4, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 da6c65856a9bda2920b701fc8f0d4f59bc863c58
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13700: Remove not needed `Completer.IRenderer.sanitizer`'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-13700-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13700 on branch 3.6.x (Remove not needed Completer.IRenderer.sanitizer)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-change A change that should be accompanied by a major version increase enhancement pkg:completer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants