Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lumino with support for plugin deactivation #13541

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

fcollonval
Copy link
Member

References

Update lumino to support jupyterlab/lumino#278

Code changes

N/A

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is going to be useful for https://github.com/jupyterlab/jupyterlab-plugin-playground 👍

According to jupyterlab/lumino#377 (comment) this was initially not meant to be backported to Lumino 1.x, but I guess this might be related to the recent change of the TypeScript target, or other reasons?

@fcollonval
Copy link
Member Author

Nice this is going to be useful for https://github.com/jupyterlab/jupyterlab-plugin-playground +1

This is exactly the reason I pushed forward.

According to jupyterlab/lumino#377 (comment) this was initially not meant to be backported to Lumino 1.x, but I guess this might be related to the recent change of the TypeScript target, or other reasons?

The backport was requiring some changes that I did not get the time to do what was necessary. And at that time I did not think it would take so long to get 3.6.0 out.

@fcollonval fcollonval merged commit c3e7f3f into jupyterlab:3.6.x Dec 6, 2022
@fcollonval fcollonval deleted the bump/lumino branch December 6, 2022 10:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants