Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets whether the model is collaborative or not when registering its factory #13526

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Dec 1, 2022

Follow-up #13458

Hi @dlqqq, @ellisonbg and @fcollonval .

I like the idea of specifying whether the document is collaborative or not. Furthermore, I believe we should make it more robust by setting it as collaborative when registering the model factory.

References

Code changes

User-facing changes

Backwards-incompatible changes

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.0 milestone Dec 5, 2022
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

@fcollonval fcollonval merged commit 4496969 into jupyterlab:master Dec 5, 2022
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Dec 5, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4496969e65e66539c1327cc59fe684f206c858d4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13526: Sets whether the model is collaborative or not when registering its factory'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-13526-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13526 on branch 3.6.x (Sets whether the model is collaborative or not when registering its factory)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@hbcarlos hbcarlos deleted the follow_up#13458 branch December 5, 2022 10:17
fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Dec 5, 2022
fcollonval added a commit that referenced this pull request Dec 5, 2022
…en registering its factory (#13538)

Co-authored-by: Carlos Herrero <contact@carloshb.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants