-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets whether the model is collaborative or not when registering its factory #13526
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hbcarlos
@meeseeksdev please backport to 3.6.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
… or not when registering its factory
…en registering its factory (#13538) Co-authored-by: Carlos Herrero <contact@carloshb.com>
Follow-up #13458
Hi @dlqqq, @ellisonbg and @fcollonval .
I like the idea of specifying whether the document is collaborative or not. Furthermore, I believe we should make it more robust by setting it as collaborative when registering the model factory.
References
Code changes
User-facing changes
Backwards-incompatible changes