New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python test dependencies #13508
Fix Python test dependencies #13508
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Looks like some Python tests (3.7?) give the following:
|
Ah, the plugin is 3.8+ currently |
Yep I opened jupyter-server/pytest-jupyter#29 Is it possible to lower the plugin package requirement or should we bump the minimal tested version to 3.8? |
The error on js-services needs to be addressed. But I'm merging as is as it solves the Python jobs to keep the ball rolling for other PRs. |
@meeseeksdev please backport to 3.6.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Actually the |
Looks like some Python checks are failing on master after this PR was merged (168a53d): https://github.com/jupyterlab/jupyterlab/actions/runs/3583498754/jobs/6028998723 |
Could be fixed by https://github.com/jupyter-server/pytest-jupyter/releases/tag/v0.5.3 |
OK thanks, so maybe just re-running the checks would be fine. |
Actually no - the renamed in jupyter-server/pytest-jupyter#32 is impacting use because I modified the fixture name in this PR. |
I'll open a follow-up fix |
…3.6.x (Fix Python test dependencies)
…st dependencies) (#13608) Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
References
Pytest fixtures for Jupyter are now part of a separate package pytest-jupyter.
Code changes
Add the new test dependency
Remove unused
ui-tests
optional group dependencyUser-facing changes
N/A
Backwards-incompatible changes
N/A