Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python test dependencies #13508

Merged
merged 4 commits into from Nov 30, 2022
Merged

Fix Python test dependencies #13508

merged 4 commits into from Nov 30, 2022

Conversation

fcollonval
Copy link
Member

References

Pytest fixtures for Jupyter are now part of a separate package pytest-jupyter.

Code changes

Add the new test dependency
Remove unused ui-tests optional group dependency

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jtpio
Copy link
Member

jtpio commented Nov 29, 2022

Looks like some Python tests (3.7?) give the following:

ERROR: Could not find a version that satisfies the requirement pytest-jupyter[server]; extra == "test" (from jupyterlab[dev,test]) (from versions: none)

@blink1073
Copy link
Member

Ah, the plugin is 3.8+ currently

@fcollonval
Copy link
Member Author

Yep I opened jupyter-server/pytest-jupyter#29

Is it possible to lower the plugin package requirement or should we bump the minimal tested version to 3.8?

@blink1073
Copy link
Member

Done: https://github.com/jupyter-server/pytest-jupyter/releases/tag/v0.5.1

@fcollonval fcollonval marked this pull request as ready for review November 29, 2022 16:45
@fcollonval
Copy link
Member Author

The error on js-services needs to be addressed. But I'm merging as is as it solves the Python jobs to keep the ball rolling for other PRs.

@fcollonval fcollonval merged commit 168a53d into master Nov 30, 2022
@fcollonval fcollonval deleted the maintenance/update-py-dep branch November 30, 2022 12:59
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 30, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 168a53dd856f48bb2ce15cc5078bd132829d2efb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13508: Fix Python test dependencies'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-13508-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR #13508 on branch 3.6.x (Fix Python test dependencies)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@fcollonval
Copy link
Member Author

Actually the js-services failures appeared before this one; see #13460

@jtpio
Copy link
Member

jtpio commented Nov 30, 2022

Looks like some Python checks are failing on master after this PR was merged (168a53d): https://github.com/jupyterlab/jupyterlab/actions/runs/3583498754/jobs/6028998723

@blink1073
Copy link
Member

@jtpio
Copy link
Member

jtpio commented Nov 30, 2022

OK thanks, so maybe just re-running the checks would be fine.

@fcollonval
Copy link
Member Author

Actually no - the renamed in jupyter-server/pytest-jupyter#32 is impacting use because I modified the fixture name in this PR.

@fcollonval
Copy link
Member Author

I'll open a follow-up fix

fcollonval added a commit that referenced this pull request Dec 1, 2022
…3514)

* Backport PR #13508: Fix Python test dependencies

* Backport #13515
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Dec 16, 2022
fcollonval added a commit that referenced this pull request Dec 16, 2022
…st dependencies) (#13608)

Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants