Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #13267 on branch 3.6.x (Ask confirmation when closing a document) #13489

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Backport #13267 on branch 3.6.x (Ask confirmation when closing a document) #13489

merged 2 commits into from
Nov 28, 2022

Conversation

fcollonval
Copy link
Member

Backport #13267

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.0 milestone Nov 25, 2022
@fcollonval fcollonval marked this pull request as ready for review November 25, 2022 13:22
@fcollonval
Copy link
Member Author

bot please update galata snapshots

@fcollonval fcollonval closed this Nov 28, 2022
@fcollonval fcollonval reopened this Nov 28, 2022
@fcollonval fcollonval merged commit 2ce1ab3 into jupyterlab:3.6.x Nov 28, 2022
@fcollonval fcollonval deleted the backport/13267-confirm-close-document branch November 28, 2022 12:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@fcollonval fcollonval

Labels
enhancement pkg:docmanager tag:Testing
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcollonval @alec-kr