Backport #12667 on branch 3.6.x (Add events service) #13465
Conversation
|
Thanks for making a pull request to jupyterlab! |
afshin
force-pushed
the
backport/12667-events-service
branch
from
2ca872c
to
b0d81ca
Compare
| @@ -16,7 +16,7 @@ | |||
| "resolveJsonModule": true, | |||
| "sourceMap": true, | |||
| "strictNullChecks": true, | |||
| "target": "es2017", | |||
| "target": "es2018", | |||
There was a problem hiding this comment.
@afshin are we ok to change that for a minor release?
There was a problem hiding this comment.
I am not sure I fully understand the ramifications. I don’t think this is backward-incompatible but I’m not 100% confident.
There was a problem hiding this comment.
This is backward incompatible in the sense that it raises the required version of web browsers.
There was a problem hiding this comment.
I think in that sense we might be okay because all the browsers we support are covered.
Do you think we have a problem?
There was a problem hiding this comment.
I guess the time of holding back on web browser update in organization is mostly over. But it is worth raising the point at a weekly call (although this week may not be the best).
Backport #12667