Extract @jupyterlab/shared-models to @jupyter-notebook/ydoc #13389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
fcollonval
added
api-change
fcollonval
changed the title
|
@meeseeksdev please backport to 3.6.x |
|
Oops, something went wrong applying the patch ... Please have a look at my logs. |
|
@meeseeksdev please backport to 3.6.x |
|
Oops, something went wrong applying the patch ... Please have a look at my logs. |
This was referenced Nov 16, 2022
|
Should the extension migration be updated to indicate that The current version still indicates the following: https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#api-breaking-changes
|
4 tasks
hbcarlos
pushed a commit
to hbcarlos/jupyterlab
that referenced
this pull request
Jan 29, 2023
…ab#13389) * Switch to @jupyter-notebook/ydoc * Move `fromJSON` in `@jupyter-notebook/ydoc` * Bump to @jupyter-notebook/ydoc 0.2.0-alpha.1 * Don't modify the staging folder * Remove shared model from CI * Fix example * Switch to final 0.2.0 ydoc release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow-up of jupyterlab/frontends-team-compass#152 (comment)
Related PR: jupyter-server/jupyter_ydoc#86
Code changes
Extract the Y document schemas in a mono repo along side the Python version of the schemas.
The
fromJSONhas been extracted too has it requires to know internal details of the document schemas; hence is better handle directly over there.User-facing changes
N/A
Backwards-incompatible changes
The API did not changed but is provided by another package.