Only show "Shut Down Kernel" if kernel is running

[krassowski]

References

Fixes #11392

Code changes

Added .jp-mod-running as explored earlier in #11392 (comment)

User-facing changes

"Shut Down Kernel" only shows up for things with a kernel

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[krassowski]

bot please update snapshots

[fcollonval]

Thanks @krassowski

Would you mind moving up a bit the fake mouse pointer in https://github.com/krassowski/jupyterlab/blob/0878902a485a4316c791c5e8baa8d90ccaeb7bd2/galata/test/documentation/general.test.ts#L217

This will keep consistent its position with the Copy Shareable Link menu entry.

[krassowski]

I was thinking if we should make the signature something like position: { x: number | ElementHandle, y: number | ElementHandle } to allow setting one of the coordinates manually while the other would be in the middle of BBox of the element. We can extract this to a new issue (along with changing the cursor to something nicer, and adding it to more screenshots).

[fcollonval]

Nice suggestion.

[krassowski]

Thanks @krassowski

Would you mind moving up a bit the fake mouse pointer in https://github.com/krassowski/jupyterlab/blob/0878902a485a4316c791c5e8baa8d90ccaeb7bd2/galata/test/documentation/general.test.ts#L217

This will keep consistent its position with the Copy Shareable Link menu entry.

Thanks, done!

[fcollonval]

Thanks @krassowski

[fcollonval]

@meeseeksdev please backport to 3.4.x

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout 3.4.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 adafbabcef3315bc706381d533d229115c07b5a6

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #12919: Only show "Shut Down Kernel" if kernel is running'

4. Push to a named branch:

git push YOURFORK 3.4.x:auto-backport-of-pr-12919-on-3.4.x

5. Create a PR against branch 3.4.x, I would have named this PR:

"Backport PR #12919 on branch 3.4.x (Only show "Shut Down Kernel" if kernel is running)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.