-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12717 Add a new section: automation of local dev environments #12806
#12717 Add a new section: automation of local dev environments #12806
Conversation
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks @markgreene74 for taking the time to document this setup 👍 This PR was discussed during the July 20th weekly meeting: jupyterlab/frontends-team-compass#152 (comment) I think the overall feeling was that it can indeed be difficult to automate a development environment for JupyterLab. There are multiple technologies involves such as Python and JavaScript / TypeScript with Node.js. So any effort to make contributing to the project easier is really appreciated! However it looked like no-one in the current JupyterLab team is familiar with Vagrant. So there is a risk the documentation will not be maintained or will become outdated. I think there is still value in mentioning the Vagrant based setup in the contributing docs. Maybe we could simply link to your repository so the folks interested can find all the information there? https://github.com/markgreene74/jupyterlab-local-dev-with-vagrant
What do you think? Thanks again for working on this! |
Hi @jtpio ! Thank you very much for the feedback. It makes perfectly sense, I will make the changes now 👍 |
11c2eec
to
9a77555
Compare
That's done now. I implemented the changes suggested (single sub-section), rebased to master and put everything in a single commit so hopefully should be easier to review. Also, made the necessary changes to the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the patience @markgreene74
Thank you for the review @fcollonval :) |
References
This PR is related to #12717.
Code changes
With this PR a new sub-section "Using automation to set up a local development environment" is added to "Setting up a local development environment" in
contributing.rst
.The sub-section contains a small description of some of the advantages and link to a working example of Vagrantfile and additional documentation.
User-facing changes
Changes to the "Contribute" documentation.
Backwards-incompatible changes
N/A, no changes to JupyterLab public APIs.