Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12717 Add a new section: automation of local dev environments #12806

Merged

Conversation

markgreene74
Copy link
Contributor

@markgreene74 markgreene74 commented Jul 16, 2022

References

This PR is related to #12717.

Code changes

With this PR a new sub-section "Using automation to set up a local development environment" is added to "Setting up a local development environment" in contributing.rst.

The sub-section contains a small description of some of the advantages and link to a working example of Vagrantfile and additional documentation.

User-facing changes

Changes to the "Contribute" documentation.

Backwards-incompatible changes

N/A, no changes to JupyterLab public APIs.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@welcome
Copy link

welcome bot commented Jul 16, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio
Copy link
Member

jtpio commented Aug 4, 2022

Thanks @markgreene74 for taking the time to document this setup 👍

This PR was discussed during the July 20th weekly meeting: jupyterlab/frontends-team-compass#152 (comment)

I think the overall feeling was that it can indeed be difficult to automate a development environment for JupyterLab. There are multiple technologies involves such as Python and JavaScript / TypeScript with Node.js. So any effort to make contributing to the project easier is really appreciated!

However it looked like no-one in the current JupyterLab team is familiar with Vagrant. So there is a risk the documentation will not be maintained or will become outdated.

I think there is still value in mentioning the Vagrant based setup in the contributing docs. Maybe we could simply link to your repository so the folks interested can find all the information there? https://github.com/markgreene74/jupyterlab-local-dev-with-vagrant
Then there could be a subsection in https://jupyterlab.readthedocs.io/en/latest/developer/contributing.html#setting-up-a-local-development-environment still called Using automation to set up a local development environment, but only keeping a small description of what it is about. For example:

While there is a lot to learn by following the steps above, they can be automated to save time. This section shows how
to do that using Vagrant as an example.
The main advantages of using automation are: reduced time to get the environment up-and-running, reduced time to
re-build the environment, better standardisation ("baseline", reproducible environments).
A practical example can be found here <https://github.com/markgreene74/jupyterlab-local-dev-with-vagrant>_ and
includes a Vagrantfile, the bootstrap files and additional documentation.

What do you think? Thanks again for working on this!

@markgreene74
Copy link
Contributor Author

Hi @jtpio !

Thank you very much for the feedback. It makes perfectly sense, I will make the changes now 👍

@markgreene74
Copy link
Contributor Author

That's done now. I implemented the changes suggested (single sub-section), rebased to master and put everything in a single commit so hopefully should be easier to review.

Also, made the necessary changes to the PR description.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the patience @markgreene74

@markgreene74
Copy link
Contributor Author

Thank you for the review @fcollonval :)

@fcollonval fcollonval merged commit 6220f06 into jupyterlab:master Aug 17, 2022
@welcome
Copy link

welcome bot commented Aug 17, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@markgreene74 markgreene74 deleted the 12717_local_dev_with_vagrant branch September 12, 2022 13:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants