-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install either jupyter-server or jupyverse #12625
base: main
Are you sure you want to change the base?
Conversation
Thanks for making a pull request to jupyterlab! |
0648100
to
5df040a
Compare
Thanks @davidbrochart for proposing this. Not being able to run JupyterLab anymore after a single |
The other option I can think of is having a new package |
Decoupling the frontend from the backend would indeed allow for more flexibility here. Just wondering whether introducing new packages might make the setup more complicated and increase the number of combinations. This also sounds similar to a couple of other ideas:
|
It would increase the number of combinations for sure (and that's the goal), but at least the "default" JupyterLab ( |
@davidbrochart during JupyterLab meeting yesterday we triaged it as something that could possibly go into 4.2 if rewritten in a way that there are no backward compatible changes (this is installing |
But a |
CLI is not intrinsically jupyter-server specific, nor should be the extension manager etc. The fact that today these might import something from jupyter-server does it mean they should to nor need to. Things like configuration (traitlets or whatever) and contribution of assets (extensions/module federation) can be defined agnostically of the server and there is no reason why these should be in yet another place. |
I talked with a few users and they still want need to just |
Depends what we mean by "all the extensions" and "traitlets configuration". Users surely want configuration, but I doubt they want it to use traitlets (and its custom file format) or a standard, widely used format like YAML. Jupyter-server probably has more extensions that Jupyverse at the moment, but who is going to use Tornado in a few years and in which position are we going to find ourselves if we don't embrace new technology? |
@davidbrochart maybe a temporary solution could be to document (in the JupyterLab docs) how to use It looks like this would otherwise involve more discussions on how to organize the different packages (and potentially the creation of metapackages). |
Thanks, I opened #16190. |
References
Closes #11101.
Code changes
Now that we have an official alternative Jupyter server (jupyverse), JupyterLab should not strictly depend on jupyter-server. The user should be able to install the back-end of their choice. This PR makes
jupyter-server
andjupyverse
optional dependencies.User-facing changes
JupyterLab should be installed with:
pip install jupyterlab[jupyter-server] # or pip install jupyterlab[jupyverse]
Backwards-incompatible changes
Installing with
pip install jupyterlab
won't be enough, and if no Jupyter server is installed, JupyterLab will show at startup: