Add scroll bar for horizontally overflowing, unshrinkable outputs

[mueslo]

References

Fixes #12070

Code changes

.jp-OutputArea-child overflow auto instead of hidden.

User-facing changes

Adds a horizontal scroll bar for the case that horizontal overflow occurs.

In the general case of no overflow, no visual changes are present.

If output scrolling is enabled, the horizontal scrollbar will appear only once scrolled to the bottom (as it is in a different place in the DOM).

Backwards-incompatible changes

None.

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[fcollonval]

Thanks for opening this PR @mueslo

The way changes are handled in JupyterLab is by always targeting the master branch and then backporting to production branch. This improves consistency and allows to backport easily to multiple branches if needed.

Could you please bring a PR against the master branch?

[mueslo]

Sorry - if this procedure was mentioned somewhere, I must have missed it. To me it looked like the master branch targeted 4.x. The master branch has reworked the `outputarea` css (grid instead of flexbox, see #11508), but I don't see it being backported. What course of action would you suggest?

…

On Fri, 18 Feb 2022, 08:19 Frédéric Collonval, ***@***.***> wrote: Thanks for opening this PR @mueslo <https://github.com/mueslo> The way changes are handled in JupyterLab is by always targeting the master branch and then backporting to production branch. This improves consistency and allows to backport easily to multiple branches if needed. Could you please bring a PR against the master branch? — Reply to this email directly, view it on GitHub <#12077 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGO7B2FQDSZTIDDDAL7CU3U3XXJRANCNFSM5OU5A2RA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[fcollonval]

No problem - and thanks for pointing out that indeed this is not mentioned - I'll correct that.

As those CSS changes are not altering the look of the notebook, for this peculiar case we can backport #11508, #11814 and the up coming one.

[mueslo]

No problem - and thanks for pointing out that indeed this is not mentioned - I'll correct that.

As those CSS changes are not altering the look of the notebook, for this peculiar case we can backport #11508, #11814 and the up coming one.

Thanks. Once #11508 is backported I think a different method can be used to bring the outputs back which will show the horizontal scroll bar at the same location in the DOM as the vertical scroll bar, which would also solve #4208

Is there any timeline of backporting those changes? Or would I need to initiate it?

[fcollonval]

Could you please change the target (or close this PR and open a new one) to address this proposal against the master branch?

[krassowski]

It looks like closing this PR and opening a new one against master branch is the way to go. @mueslo are you still interested?