Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin id for the toolbar registry plugin #11899

Merged
merged 1 commit into from Jan 20, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 19, 2022

References

For consistency with the other @jupyterlab plugins.

Noticed when updating RetroLab to the latest @jupyterlab packages: jupyterlab/retrolab#319

Code changes

Rename plugin id.

User-facing changes

None

Backwards-incompatible changes

None (4.0 still in alpha cycle)

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@jtpio jtpio added this to the 4.0 milestone Jan 19, 2022
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @jtpio.

We will need to backport it to 3.3.x after #11873 is in.

I added this as part of #11873 for 3.3

fcollonval added a commit to fcollonval/jupyterlab that referenced this pull request Jan 20, 2022
@jtpio
Copy link
Member Author

jtpio commented Jan 20, 2022

I added this as part of #11873 for 3.3

Sounds good, thanks 👍

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 3985 <- [4072 - 4138 - 4208] -> 4385 2589 <- [2703 - 2748 - 2807] -> 3292
expected 3842 <- [3978 - 4118 - 4212] -> 8439 2655 <- [2772 - 2802 - 2875] -> 3448
Mean relative change -0.4% ± 2.2% -2.4% ± 1.0%
switch-from
chromium
actual 658 <- [740 - 762 - 787] -> 979 451 <- [492 - 502 - 516] -> 701
expected 656 <- [725 - 750 - 779] -> 929 476 <- [500 - 509 - 519] -> 542
Mean relative change 1.8% ± 2.1% -1.0% ± 1.2%
switch-to
chromium
actual 315 <- [378 - 386 - 395] -> 501 264 <- [284 - 291 - 300] -> 347
expected 312 <- [376 - 385 - 395] -> 518 257 <- [284 - 292 - 299] -> 699
Mean relative change -0.2% ± 1.8% -1.1% ± 2.9%
close
chromium
actual 577 <- [965 - 984 - 999] -> 2226 474 <- [496 - 505 - 515] -> 573
expected 557 <- [953 - 974 - 990] -> 1037 477 <- [497 - 505 - 515] -> 544
Mean relative change 3.0% ± 4.4% -0.2% ± 0.8%

Changes are computed with expected as reference.

@jtpio jtpio merged commit ea1529b into jupyterlab:master Jan 20, 2022
@jtpio jtpio deleted the fix-plugin-id branch January 20, 2022 15:17
fcollonval added a commit that referenced this pull request Jan 23, 2022
…tomize easily toolbar items.) (#11873)

* Backport PR #10469: Allow extensions and users to customize easily toolbar items.

* Backport #11899

* Fix doc

* Remove duplicate entry in setting

* Backport #10880
It seems the automatic backport in 3.1.x by the bot did not make it

* Fix doc snippets

* Fix test import

* Fix `ToolbarButton`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants