Fix for Code Mirror width. Requested changes implemented #11809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
Design System CSS
pkg:cells
pkg:outputarea
tag:CSS
fcollonval
requested changes
Jan 10, 2022
There was a problem hiding this comment.
Thanks a lot @pree-T
This looks good on Binder.
The linter is complaining. It should be happy with the suggestions I added.
| @@ -59,7 +60,7 @@ | |||
| .jp-InputArea-editor { | |||
| display: table-row; | |||
| margin-left: var(--jp-notebook-padding); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Missing white spaces:
Suggested change
| } | |
| } |
packages/cells/style/widget.css
Outdated
| @@ -93,7 +93,7 @@ | |||
| } | |||
|
|
|||
| .jp-CodeCell.jp-mod-outputsScrolled .jp-OutputArea-prompt { | |||
| min-width: calc( | |||
| width: calc( | |||
There was a problem hiding this comment.
Over indentation
Suggested change
| width: calc( | |
| width: calc( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the Codemirror Width issue #11805 ,implemented the changes asked in the last PR review.
Kindly check.
Fixes #11696