New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Install
, Update
and Uninstall
buttons from the extension manager UI
#11751
Conversation
Thanks for making a pull request to jupyterlab! |
If we decide to move forward with this for 4.0, we can then open follow-up PRs to remove more code handling the source extensions (installing, updating, uninstalling) |
Thanks @jtpio for starting this.
I'm unsure we want to remove the buttons per se. The target is to provide an API that an extension could fulfill as extension provider. So I would suggest that the provider should only care about listing/installing/uninstalling extensions with the UI provided by the core extension.
❤️ |
That would indeed be the best long term goal. But since it's unclear if anyone is working on this and the extension manager for 4.0, this PR proposes to solve the more pressing issue of being able to install source extensions and confusing end users. Which seems to have also been a recurring topic at the weekly meetings (for example: jupyterlab/frontends-team-compass#128 (comment)) |
dcf92b4
to
e378874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one. Your argument makes sense.
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
References
Incremental step towards #10554 and #11336.
To improve and unify the user experience around installing extensions, which is at the moment confusing.
And help reduce the number of "JupyterLab failed to build" issues as mentioned in the
<details>
section of #10554 (comment).Code changes
This PR:
Install
,Update
andUninstall
buttons in the extension managerEnable
andDisable
prebuilt extensionsUser-facing changes
Before
After
Backwards-incompatible changes
None (UI only)