-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User defined default viewer take precedence for rendered factory #11541
User defined default viewer take precedence for rendered factory #11541
Conversation
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
This fixes #10875 - should we backport it? |
I don't think it fixes that issue because this addresses a corner case: the viewer to pick when a local file is opened from a link in a markdown cell for example). Before this PR, the user settings was ignored when looking for the viewer is that case. |
@meeseeksdev please backport to 3.6.x |
References
Fix #7776
Code changes
Look first in user overrides list for rendered widget so it takes precedence.
User-facing changes
Some link may open with a different editor if they change the default viewer settings.
Backwards-incompatible changes
N/A