Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust UI tests #10950

Merged
merged 6 commits into from
Aug 31, 2021
Merged

More robust UI tests #10950

merged 6 commits into from
Aug 31, 2021

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Aug 29, 2021

More robust Galata tests

References

Follow up of #10796

Code changes

N/A

User-facing changes

N/A

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval modified the milestones: 4.0, 3.2.x Aug 30, 2021
@blink1073 blink1073 mentioned this pull request Aug 30, 2021
@fcollonval fcollonval changed the title More robust reload test More robust UI tests Aug 30, 2021
@blink1073
Copy link
Member

Failure here is related to failures seen in #10961, which seem to be unrelated, kicking both PRs.

@fcollonval fcollonval marked this pull request as ready for review August 31, 2021 06:28
@fcollonval
Copy link
Member Author

Thanks @blink1073
This is ready for review.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 0e27e5d into master Aug 31, 2021
@jtpio jtpio deleted the fcollonval-patch-1 branch August 31, 2021 07:53
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants