Upgrade jlpm cmd to yarn 3.x

[telamonian]

I followed the migration guide, and suprisingly it mostly seems to work. Needs way more testing/poking at

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[jtpio]

Thanks for starting this!

Looks like there are a couple of conflicts to fix for the CI to be triggered.

[telamonian]

up to 42/63 checks passing as of 4388e02. Woo!

[blink1073]

Needs another rebase from #10796

[telamonian]

Needs another rebase from #10796

that's gonna happen a lot. Both package.json and yarn.lock underwent large scale formatting changes, so any other PR that touches either of those is going to trigger the need for yet another rebase (YAR?)

[blink1073]

YAR indeed. Happy to merge this sooner than later to avoid the churn

[telamonian]

@blink1073 There's still a couple of chewy issues that probably boil down to pathing but aren't obvious how to fix:

1. win and mac tests fail at first run of ensure-buildutils.js (which happens as part of pip install), while linux tests run ensure-buildutils.js just fine

• specifically, the first call to npm run build in the buildutils pkg (where the relevant script is "build": "tsc") fails on win and mac
• error:

         ➤ YN0000: │ @jupyterlab/repo-top@workspace:. STDERR sh: tsc: command not found
  

2. the "dynamic" installation of playwright that happens as part of browser_check.py is no longer producing a functional install

• the existing code for this is here:
  

  jupyterlab/jupyterlab/browser_check.py

  Lines 147 to 157 in 93c79b6

  	async def run_browser(url):
  	"""Run the browser test and return an exit code.
  	"""
  	target = osp.join(get_app_dir(), 'browser_test')
  	if not osp.exists(osp.join(target, 'node_modules')):
  	if not osp.exists(target):
  	os.makedirs(osp.join(target))
  	await run_async_process(["jlpm", "init", "-y"], cwd=target)
  	await run_async_process(["jlpm", "add", "playwright@^1.9.2"], cwd=target)
  	shutil.copy(osp.join(here, 'browser-test.js'), osp.join(target, 'browser-test.js'))
  	await run_async_process(["node", "browser-test.js", url], cwd=target)

• running a browser check will eventually result in:

  Error: Cannot find module 'playwright'`
  

which is raised from a require('playwright'); call in browser_check.js

[blink1073]

ACK, I can take a look but probably not until Tuesday

[telamonian]

I seem to have been able to fix the tsc bug by changing various scripts such as "build": "tsc" to "build": "yarn run tsc". Similarly, I was able to fix the browser_check.py bug by changing the subprocess call from node ... to jlpm node ...:

await run_async_process(["jlpm", "node", "browser-test.js", url], cwd=target) 

[telamonian]

I've solved the issues above, but I've run into another major snag: jupyter lab build hangs the CI. It'll run for 30+ minutes and do nothing. I've tried adding the --minimize=False flag and a bunch of other tweaks, but it just doesn't work.

On the other hand, jupyter lab build runs just fine locally. Somehow it seems to be panicking the CI container

[jtpio]

I've solved the issues above, but I've run into another major snag: jupyter lab build hangs the CI. It'll run for 30+ minutes and do nothing. I've tried adding the --minimize=False flag and a bunch of other tweaks, but it just doesn't work.

Does it give more information with --debug?