New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix closing answered issues by setting the stale-issue-message attribute #10553
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
I filed an issue with the action at actions/stale#521. It seems the |
…ute. In the upcoming action version 4, we can omit both the skip-stale-issue-message and the stale-issue-message.
Update: it looks like we still need the skip option until the action releases v4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This change didn't seem to work: https://github.com/jupyterlab/jupyterlab/runs/3004704380?check_suite_focus=true#step:2:4019 |
On the other hand, interestingly, this run from this morning (several hours after this PR was merged) does not indicate that the stale-issue-message was set: https://github.com/jupyterlab/jupyterlab/runs/3004704380?check_suite_focus=true#step:2:2 Maybe we'll let it run another day or two to see about picking up this change? |
If this change does not end up working, then I think we should just wait for the upcoming v4 of this action that removes this error and streamlines this api. |
References
Follow-up to #10536 after noticing that the closures are still not happening.
Code changes
We are seeing an error that prevents issues from getting marked as closing (https://github.com/jupyterlab/jupyterlab/runs/2994705101?check_suite_focus=true#step:2:3995):
In the upcoming action version 4, we can omit both the skip-stale-issue-message and the stale-issue-message.
User-facing changes
Backwards-incompatible changes