Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing answered issues by setting the stale-issue-message attribute #10553

Merged
merged 1 commit into from Jul 6, 2021

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jul 6, 2021

References

Follow-up to #10536 after noticing that the closures are still not happening.

Code changes

We are seeing an error that prevents issues from getting marked as closing (https://github.com/jupyterlab/jupyterlab/runs/2994705101?check_suite_focus=true#step:2:3995):

[#5869] Skipping this issue because it should be marked as stale based on the option days-before-stale (​https://github.com/actions/stale#days-before-stale​) (30) but the option stale-issue-message (​https://github.com/actions/stale#stale-issue-message​) is not set

In the upcoming action version 4, we can omit both the skip-stale-issue-message and the stale-issue-message.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 3.1 milestone Jul 6, 2021
@jasongrout
Copy link
Contributor Author

I filed an issue with the action at actions/stale#521.

It seems the skip-stale-issue-message option was removed in actions/stale#457

…ute.

In the upcoming action version 4, we can omit both the skip-stale-issue-message and the stale-issue-message.
@jasongrout
Copy link
Contributor Author

Update: it looks like we still need the skip option until the action releases v4.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasongrout jasongrout merged commit 936e421 into jupyterlab:master Jul 6, 2021
@jasongrout
Copy link
Contributor Author

@jasongrout
Copy link
Contributor Author

On the other hand, interestingly, this run from this morning (several hours after this PR was merged) does not indicate that the stale-issue-message was set: https://github.com/jupyterlab/jupyterlab/runs/3004704380?check_suite_focus=true#step:2:2

Maybe we'll let it run another day or two to see about picking up this change?

@jasongrout
Copy link
Contributor Author

If this change does not end up working, then I think we should just wait for the upcoming v4 of this action that removes this error and streamlines this api.

@jasongrout jasongrout deleted the answer3 branch July 8, 2021 03:08
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants