Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove content-visibility css prop to avoid jumpy scrollbar #10503

Merged

Conversation

echarles
Copy link
Member

@echarles echarles commented Jun 29, 2021

References

Fixes #10428

Code changes

Remove content-visibility css prop to avoid jumpy scrollbar. This had been identified during the work on the 2.3 branch, but for some reason, the content-visibility prop has been pulled in master branch. This property does not bring any value to the performance as the virtual rendering is ensured by ad-hoc intersection observer.

User-facing changes

No more jumpy scrollbar as reported in #10428 (comment)

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added Design System CSS pkg:notebook tag:CSS For general CSS related issues and pecadilloes labels Jun 29, 2021
@blink1073 blink1073 added the bug label Jun 29, 2021
@blink1073 blink1073 added this to the 3.1 milestone Jun 29, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I kicked the CodeQL build

@echarles
Copy link
Member Author

Thx @blink1073

CodeQL is failing with the following unrelated?

  [2021-06-29 15:21:25] [build-stderr] Could not compute type of Identifier at /home/runner/work/jupyterlab/jupyterlab/packages/services/src/kernel/messages.ts:135:11
  [2021-06-29 15:21:25] [build-stderr] Could not compute type of Identifier at /home/runner/work/jupyterlab/jupyterlab/packages/services/src/kernel/messages.ts:135:11
  [2021-06-29 15:21:25] [build-stdout] Done extracting /home/runner/work/jupyterlab/jupyterlab/packages/services/src/kernel/manager.ts (110 ms)
  [2021-06-29 15:21:25] [build-stdout] Extracting /home/runner/work/jupyterlab/jupyterlab/packages/services/src/kernel/messages.ts
  [2021-06-29 15:21:25] [build-stdout] Done extracting /home/runner/work/jupyterlab/jupyterlab/packages/services/src/kernel/manager.ts (110 ms)
  [2021-06-29 15:21:25] [build-stdout] Extracting /home/runner/work/jupyterlab/jupyterlab/packages/services/src/kernel/messages.ts
  [2021-06-29 15:21:25] [build-stderr] /opt/hostedtoolcache/CodeQL/0.0.0-20210622/x64/codeql/javascript/tools/typescript-parser-wrapper/node_modules/typescript/lib/typescript.js:65953
  [2021-06-29 15:21:25] [build-stderr]             function getTypeAtFlowNode(flow) {
  [2021-06-29 15:21:25] [build-stderr]                                       ^
  [2021-06-29 15:21:25] [build-stderr] RangeError: Maximum call stack size exceeded

@blink1073
Copy link
Member

You're right, it started failing in master and in #10462 as well today.

@blink1073 blink1073 merged commit 8c15f77 into jupyterlab:master Jun 29, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Design System CSS pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll Bar Bug
2 participants