Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for namespace packages in labextensions. #10150

Merged
merged 1 commit into from Apr 24, 2021

Conversation

mellesies
Copy link
Contributor

References

Fix for issue #10149

Code changes

Added logic to search for namespace packages if no regular packages can be found.

User-facing changes

None

Backwards-incompatible changes

None

@welcome
Copy link

welcome bot commented Apr 24, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone Apr 24, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 521b928 into jupyterlab:master Apr 24, 2021
@welcome
Copy link

welcome bot commented Apr 24, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073
Copy link
Member

@meeseeksdev please backport to 3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 24, 2021
blink1073 pushed a commit that referenced this pull request Apr 25, 2021
…ions. (#10151)

Co-authored-by: Melle Sieswerda <mellesies@users.noreply.github.com>
@bollwyvl
Copy link
Contributor

Awesome, thanks!

cameron-toy pushed a commit to cameron-toy/jupyterlab that referenced this pull request May 28, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants