Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update extension_tutorial #10026

Merged
merged 3 commits into from Apr 10, 2021
Merged

chore: update extension_tutorial #10026

merged 3 commits into from Apr 10, 2021

Conversation

0618
Copy link
Contributor

@0618 0618 commented Mar 31, 2021

References

#10017

Code changes

  • Update command palette, etc.
  • Update screenshots

chore: update extension_tutorial
7824b23 
- Update `command palette`, etc.
- Update screenshots
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone Mar 31, 2021
@0618 0618 force-pushed the update-extension-tutorial branch from 92af65b to a1c9b6f Compare April 1, 2021 04:22
@0618 0618 requested a review from jtpio April 4, 2021 23:01
@jtpio
Copy link
Member

jtpio commented Apr 7, 2021

Thanks, looks good on the docs preview!

https://jupyterlab--10026.org.readthedocs.build/en/10026/extension/extension_tutorial.html

Minor nit-pick: would it be possible to use the same complete screenshot for the preview at the top? So it shows the same image that corresponds to the link in the legend:

image

@0618
Copy link
Contributor Author

0618 commented Apr 10, 2021

Thanks, looks good on the docs preview!

https://jupyterlab--10026.org.readthedocs.build/en/10026/extension/extension_tutorial.html

Minor nit-pick: would it be possible to use the same complete screenshot for the preview at the top? So it shows the same image that corresponds to the link in the legend:

image

Good catch. Screenshots are updated!

jtpio
jtpio approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit b448873 into jupyterlab:master Apr 10, 2021
@jtpio jtpio mentioned this pull request Apr 10, 2021
Closed
@jtpio
Copy link
Member

jtpio commented Apr 12, 2021

@meeseeksdev please backport to 3.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 12, 2021
@jtpio @meeseeksmachine
Backport PR jupyterlab#10026: chore: update extension_tutorial
063b82a
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 12, 2021
Merged
blink1073 pushed a commit that referenced this pull request Apr 12, 2021
@meeseeksmachine @jtpio
Backport PR #10026: chore: update extension_tutorial (#10081)
4c98874 
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0618 @jtpio @blink1073