Update session and kernel manager data only if there was a real change. #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to update. This was accidentally comparing extra information the server gives us, and in particular the last activity time was *always* forcing an update. Instead, we just check relevant attributes to determine if we need to update. Fixes jupyterlab#9133
…e is needed. This solves the same problem as the previous commit, but for kernels.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Closed
ellisonbg
approved these changes
Oct 22, 2020
|
@meeseeksdev backport to 2.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Oct 22, 2020
…nly if there was a real change.
ajbozarth
added a commit
that referenced
this pull request
Oct 23, 2020
…9-on-2.2.x Backport PR #9189 on branch 2.2.x (Update session and kernel manager data only if there was a real change.)
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #9133
Code changes
The rest api returns more information than we expect (according to our typing), like a last activity indicator on a kernel, which always updates. This means that our existing deep compare of the model we have and the model on the server always updates what we have, which triggers a reconnection to the kernel.
An alternative to this approach of hand-coding which attributes is to strip these extra attributes off in the response validation stage, for example in
jupyterlab/packages/services/src/session/validate.ts
Line 13 in 34cb2d3
User-facing changes
Websocket kernel connections are not continually created, as described in #9133
Backwards-incompatible changes