Fix changing font size in text editor #16261
Conversation
|
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Thanks @FoSuCloud
I spotted a small glitch that the gutter line number is not updated right away when changing the font size; example when increasing the font size
CodeMirror does update the font size of the gutter if I switch back and forth to the file editor. I guess forcing an update after updating the font size may smooth the user experience.
| @@ -103,4 +103,42 @@ ut elit.` | |||
| const tabHandle = await page.activity.getPanelLocator(DEFAULT_NAME); | |||
| expect(await tabHandle?.screenshot()).toMatchSnapshot(imageName); | |||
| }); | |||
|
|
|||
| test.describe('Changing a text editor font-size', () => { | |||
There was a problem hiding this comment.
Thanks a lot for adding a test for this ❤️
Thanks for knowing the problem, I will force update the number of lines after updating the font size |
|
It seems that the "should Decrease Content Font Size" and "should Increase Content Font Size" test cases failing have nothing to do with the pr here |
krassowski
changed the title
|
@meeseeksdev please backport to 4.1.x |
Co-authored-by: FoSuCloud <49218295+FoSuCloud@users.noreply.github.com>
References
Fixes: #16182
Code changes
packages/fileeditor-extension/src/commands.ts
User-facing changes
no
Backwards-incompatible changes
no