Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable "Search Cell Outputs" in Find/Replace, disable "Replace" button when an output is highlighted #15966

Open
JasonWeill opened this issue Mar 11, 2024 · 7 comments · May be fixed by #16157 or #16260
Open

Enable "Search Cell Outputs" in Find/Replace, disable "Replace" button when an output is highlighted #15966

JasonWeill opened this issue Mar 11, 2024 · 7 comments · May be fixed by #16157 or #16260
Labels
enhancement good first issue pkg:documentsearch tag:Search and Replace

Comments

@JasonWeill
Copy link
Contributor

This is a follow up to #13167.

When a user searches for something, and has the "Replace" option enabled, we now disable the "Search Cell Outputs" feature. This is because outputs cannot be modified directly, but this may miss a user expectation: users expect that they can still search cell outputs, but only replace writable content.

Re-enable "Search Cell Outputs" all the time, even when the "Replace" options are showing. After searching, the "Replace" button should be disabled if the currently highlighted match is in a cell output. The "Replace All" button should replace all matches except for those in cell outputs.
@JasonWeill JasonWeill added enhancement status:Needs Triage Applied to new issues that need triage labels Mar 11, 2024
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Mar 12, 2024
@JasonWeill JasonWeill mentioned this issue Mar 12, 2024
Open
@fcollonval
Copy link
Member

The code is located there:

jupyterlab/packages/documentsearch/src/searchview.tsx

Line 258 in ee99e3c

<button

@kguptas
Copy link
Contributor

kguptas commented Apr 3, 2024

Hi - would I be able to claim this issue?

@krassowski
Copy link
Member

@kguptas feel welcome to open a PR. If you have questions please feel free to ask; as a reference https://jupyterlab.readthedocs.io/en/latest/developer/contributing.html should include some basic information on setup/contributing.

@BrunoNeira-cmu
Copy link

BrunoNeira-cmu commented Apr 9, 2024 •
edited

Our team can work on this now. @kguptas are you still working on this?

Tanmay-Deshmukh added a commit to Tanmay-Deshmukh/jupyterlab that referenced this issue Apr 13, 2024
@Tanmay-Deshmukh
Fix for issue jupyterlab#15966. Cell outputs searched even when repla…
2b07cbb 
…ce is active, replace button is disabled when highlighting an output, and replace all only replaces editable strings.
@Tanmay-Deshmukh Tanmay-Deshmukh linked a pull request Apr 13, 2024 that will close this issue
Draft
@Tanmay-Deshmukh
Copy link
Contributor

This issue has been left for a few days now, I've submitted a fix so please take a look whenever you get the chance!

@JasonWeill
Copy link
Contributor Author

@Tanmay-Deshmukh Thank you for opening a PR! I'll take a look early next week. Thank you for your patience!

@krassowski
Copy link
Member

Re-enable "Search Cell Outputs" all the time, even when the "Replace" options are showing.

Duplicate of #15445

@BrunoNeira-cmu BrunoNeira-cmu linked a pull request Apr 28, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue pkg:documentsearch tag:Search and Replace
Projects
None yet
Milestone
No milestone
6 participants
@krassowski @fcollonval @kguptas @JasonWeill @BrunoNeira-cmu @Tanmay-Deshmukh