Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky js-services check on CI #13460

Closed
jtpio opened this issue Nov 21, 2022 · 2 comments
Closed

Flaky js-services check on CI #13460

jtpio opened this issue Nov 21, 2022 · 2 comments

Comments

@jtpio
Copy link
Member

jtpio commented Nov 21, 2022

Description

The js-services check on CI has been flaky for quite a while now.

Reproduce

Here is an example run on the latest commit (7901329) on master: https://github.com/jupyterlab/jupyterlab/actions/runs/3516180912/jobs/5892407924

image

Expected behavior

This check should fail less often so we are back to PRs with all-green checks ✔️

@jtpio jtpio added bug status:Needs Triage Applied to new issues that need triage labels Nov 21, 2022
@fcollonval
Copy link
Member

I'm working to bump Jest to v29 in #12584

We will then be able to take advantage of the github action reporter to ease failure analysis as the log for those tests is too long to be handled in GitHub and the ansi color makes the raw format though to work with.

@jtpio
Copy link
Member Author

jtpio commented Dec 20, 2022

So js-services is now passing on the latest master: https://github.com/jupyterlab/jupyterlab/actions/runs/3738704614/jobs/6345071954

Closing as fixed by ipython/ipykernel#1056.

@jtpio jtpio closed this as completed Dec 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants