Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A high severity vulnerability introduced in @jupyterlab/buildutils #10818

Closed
ayaka-kms opened this issue Aug 12, 2021 · 2 comments · Fixed by #10828
Closed

A high severity vulnerability introduced in @jupyterlab/buildutils #10818

ayaka-kms opened this issue Aug 12, 2021 · 2 comments · Fixed by #10828
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Comments

@ayaka-kms
Copy link

ayaka-kms commented Aug 12, 2021

Hi, a vulnerability CVE-2021-27290 is introduced in npm-cli-login via:
● @jupyterlab/buildutils@3.1.6 ➔ npm-cli-login@0.1.1 ➔ npm-registry-client@8.6.0 ➔ ssri@5.3.0

However, npm-cli-login is a legacy package, which has not been maintained for about 3 years.
Is it possible to migrate npm-cli-login to other package or remove it to remediate this vulnerability?

I noticed several migration records in other js repo for npm-cli-login:

● in @cloudant/cloudant, version 4.1.0 ➔ 4.1.1, remove recompose via commit

Thanks.

@ayaka-kms ayaka-kms added the bug label Aug 12, 2021
@welcome
Copy link

welcome bot commented Aug 12, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski
Copy link
Member

Hi @ayaka-kms thank you for the nudge on this one. This dependency was only used for testing and not invoked in user-facing part ever so it should not be a problem given that the vulnerability in question is a ReDoS. Still, the package in question was indeed outdated and unnecessary dependency and it was just removed in #10828.

In future, if you discover a security vulnerability in JupyterLab, or are confident that a vulnerability in a dependency makes JupyterLab vulnerable (which fortunately was not the case here) you can follow the responsible disclosure guidelines and report it to the address shown in the JupyterLab security policy.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants