Remove outdated npm-cli-login utility from buildutils
#10828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
krassowski
force-pushed
the
remove-npm-cli-login
branch
6 times, most recently
from
977bc64
to
e1ac4fe
Compare
as suggested in npm/npm#11320 (comment)
krassowski
force-pushed
the
remove-npm-cli-login
branch
from
e1ac4fe
to
98158fa
Compare
and add other suggestions from offline chat
krassowski
force-pushed
the
remove-npm-cli-login
branch
from
25a1f6a
to
77075df
Compare
|
@meeseeksdev please backport to 3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 13, 2021
… from buildutils
blink1073
pushed a commit
that referenced
this pull request
Aug 13, 2021
…dutils (#10832) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
|
Thank you @blink1073! |
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #10818 by removing
npm-cli-login. Also reduces the yarn.lock by 11% :)Code changes
Added a dependency-free alternative using
spawnand communicating withnpm loginprocess.User-facing changes
None
Backwards-incompatible changes
None