Skip to content

Commit

Permalink
Use the root yarn.lock in staging when making a release. (#11433)
Browse files Browse the repository at this point in the history
Fixes #11429

Essentially, since we were creating a new yarn.lock when making a release, we were possibly upgrading dependencies in a release that we were not using in our dev branches. This meant we could introduce changes or regressions right when making a release that we would not see in our dev workflow. This change locks the release to the versions of packages we had been using in the dev process.
  • Loading branch information
jasongrout committed Nov 11, 2021
1 parent cbcd52f commit b228e5d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion buildutils/src/update-core-mode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,11 @@ const notice =
}
});

// Create a new yarn.lock file to ensure it is correct.
// Copy the root yarn.lock, then update and deduplicate to prune it.
fs.copySync(
path.join('.', 'yarn.lock'),
path.join('.', 'jupyterlab', 'staging', 'yarn.lock')
);
utils.run('jlpm', { cwd: staging });
try {
utils.run('jlpm yarn-deduplicate -s fewer --fail', { cwd: staging });
Expand Down

0 comments on commit b228e5d

Please sign in to comment.