Skip to content

Commit

Permalink
More fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Mar 17, 2024
1 parent 5f606a4 commit 4e8acd0
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
retention-days: 1

python-linux-tests:
name: Linux ${{ matrix.group }} python test
name: Linux ${{ matrix.group }} test
needs: build
strategy:
matrix:
Expand All @@ -61,12 +61,13 @@ jobs:
# FIXME upload artifacts

python-macos-tests:
name: macOS ${{ matrix.group }} python test
name: macOS ${{ matrix.group }} test
# Run costly MacOS jobs only if Linux tests are passing
needs: python-linux-tests
strategy:
matrix:
group: [integrity, python, usage, usage2]
python-version: ["3.11"]
fail-fast: false
timeout-minutes: 45
runs-on: macos-latest
Expand All @@ -91,12 +92,13 @@ jobs:
bash ./scripts/ci_script.sh
python-windows-tests:
name: Windows ${{ matrix.group }} python test
name: Windows ${{ matrix.group }} test
# Run costly Windows jobs only if Linux tests are passing
needs: python-linux-tests
strategy:
matrix:
group: [integrity, python]
python-version: ["3.11"]
fail-fast: false
runs-on: windows-latest
timeout-minutes: 40
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -19883,8 +19883,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "test-hyphens-underscore@workspace:jupyterlab/tests/mock_packages/test-hyphens-underscore"
dependencies:
"@jupyterlab/builder": ^4.1.2
"@jupyterlab/launcher": ^4.1.2
"@jupyterlab/builder": ^4.2.0-alpha.1
"@jupyterlab/launcher": ^4.2.0-alpha.1
"@types/react": ^18.0.26
css-loader: ^6.7.1
rimraf: ~5.0.5
Expand All @@ -19898,8 +19898,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "test-hyphens@workspace:jupyterlab/tests/mock_packages/test-hyphens"
dependencies:
"@jupyterlab/builder": ^4.1.2
"@jupyterlab/launcher": ^4.1.2
"@jupyterlab/builder": ^4.2.0-alpha.1
"@jupyterlab/launcher": ^4.2.0-alpha.1
"@types/react": ^18.0.26
css-loader: ^6.7.1
rimraf: ~5.0.5
Expand All @@ -19913,8 +19913,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "test_no_hyphens@workspace:jupyterlab/tests/mock_packages/test_no_hyphens"
dependencies:
"@jupyterlab/builder": ^4.1.2
"@jupyterlab/launcher": ^4.1.2
"@jupyterlab/builder": ^4.2.0-alpha.1
"@jupyterlab/launcher": ^4.2.0-alpha.1
"@types/react": ^18.0.26
css-loader: ^6.7.1
rimraf: ~5.0.5
Expand Down

0 comments on commit 4e8acd0

Please sign in to comment.