Skip to content

Commit

Permalink
Update label for new notebook on context menu
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Aug 11, 2021
1 parent 744878d commit 12fc78b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion packages/notebook-extension/schema/tracker.json
Expand Up @@ -350,7 +350,10 @@
{
"command": "notebook:create-new",
"selector": ".jp-DirListing-content",
"rank": 52
"rank": 52,
"args": {
"isContextMenu": true
}
}
]
},
Expand Down
2 changes: 1 addition & 1 deletion packages/notebook-extension/src/index.ts
Expand Up @@ -1225,7 +1225,7 @@ function activateNotebookHandler(
''
);
}
if (args['isPalette']) {
if (args['isPalette'] || args['isContextMenu']) {
return trans.__('New Notebook');
}
return trans.__('Notebook');
Expand Down
Binary file modified ui-tests/reference-output/screenshots/contextmenu_file.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/reference-output/screenshots/contextmenu_folder.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 12fc78b

Please sign in to comment.