Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc to run benchmark against expected UI changes #125

Merged
merged 1 commit into from Nov 2, 2022
Merged

Add doc to run benchmark against expected UI changes #125

merged 1 commit into from Nov 2, 2022

Conversation

suganya-sk
Copy link
Contributor

For #117

@welcome
Copy link

welcome bot commented Oct 29, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@suganya-sk suganya-sk mentioned this pull request Oct 29, 2022
Closed
fcollonval
fcollonval approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suganya-sk

@fcollonval fcollonval merged commit e1a2938 into jupyterlab:master Nov 2, 2022
@welcome
Copy link

welcome bot commented Nov 2, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval linked an issue Nov 2, 2022 that may be closed by this pull request
Running benchmark across versions with UI changes #117
Closed
@suganya-sk suganya-sk deleted the update-doc-for-benchmarks branch December 7, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running benchmark across versions with UI changes
2 participants
@suganya-sk @fcollonval