Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update to JupyterLab 4 #1340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Mar 28, 2024

Extract the part of #1302 to update to JupyterLab 4, without the Notebook 7 update.

@jtpio jtpio marked this pull request as ready for review March 28, 2024 16:56
@jtpio jtpio changed the title Update to JupyterLab 4 [MRG] Update to JupyterLab 4 Mar 28, 2024
@manics manics mentioned this pull request Mar 28, 2024
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio! This looks good to me. I think the following are breaking-ish changes:

  1. jupyter-server version to 2.x (how much of a breaking change is this?)
  2. Support for python 3.7 in the base environment is now gone. How does this affect repos that specify python 3.7?
  3. jupyterlab to 4.x (so some extensions would break)

I don't fully understand (2), but otherwise with labeling this looks good to me.

@jtpio
Copy link
Contributor Author

jtpio commented Mar 29, 2024

jupyter-server version to 2.x (how much of a breaking change is this?)

The default CMD still launches the old server via jupyter notebook it seems though?

CMD ["jupyter", "notebook", "--ip", "0.0.0.0"]

Support for python 3.7 in the base environment is now gone. How does this affect repos that specify python 3.7?

Python 3.7 reached end of life in June 2023: jupyterlab/jupyterlab#13745. JupyterLab 4 requires Python 3.8 now.

jupyterlab to 4.x (so some extensions would break)

Yes, although many have been updated now: jupyterlab/jupyterlab#14590

Also JupyterLab 3 will reach end of maintenance soon: jupyterlab/jupyterlab#15921

@minrk
Copy link
Member

minrk commented May 21, 2024

How does this affect repos that specify python 3.7?

They are unaffected at the moment. As this PR stands, 3.7 stops getting updates, but continues to be supported for the server environment.

The next stage of reduced support is bumping kernel_env_cutoff_version to 3.8, at which point 3.7 becomes a 'kernel-only' version, like 3.6 and older. I think would be reasonable to make this change here as well, but not required.

Pro bumping kernel_env_cutoff:

  • all installs get the same jupyterlab/server versions
  • we will need to make this transition eventually, when e.g. a security requirement requires bumping a no-longer-supported package

Con:

  • bigger, more disruptive change for 3.7-using repos

Since there is no visible effect on 3.7 repos, I think it's fine to merge this as-is.

@manics
Copy link
Member

manics commented May 21, 2024

This may break users who are installing extensions which aren't compatible with JupyterLab 3. I think we should make an announcement on https://discourse.jupyter.org before merging.

@minrk
Copy link
Member

minrk commented May 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants