Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Branch input placeholder no longer suggests master branch #180

Merged
merged 1 commit into from May 29, 2021

Conversation

sean-morris
Copy link
Contributor

The placeholder that indicated a default branch name is removed from the
branch field and the message instructing the user as to how the branch
name is handled is updated

The placeholder that indicated a default branch name is removed from the
branch field and the message instructing the user as to how the branch
name is handled is updated
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The CircleCI error says it didn't detect a .circleci/config.yml, this is just weird and I'm ignoring it.

@consideRatio consideRatio merged commit df041b2 into jupyterhub:gh-pages May 29, 2021
@welcome
Copy link

welcome bot commented May 29, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@consideRatio
Copy link
Member

@sean-morris oooooooooooh this was a PR to gh-pages, I wonder if that should be done to the main branch instead and then the gh-pages branch is automatically updated.

@consideRatio
Copy link
Member

@sean-morris yepp, see the commit history of the gh-pages branch. It is built and updated automatically. Can you find the source code that you should change that give rise to this in the main branch and update it there?

See https://github.com/jupyterhub/nbgitpuller/commits/gh-pages for an indication of this btw.

I'm not sure if I caused an issue merging this, but I think I didn't. It should be updated in the main branch though because otherwise i think it will be overridden on next PR merged.

@consideRatio consideRatio changed the title Branch field no longer suggests default UI: Branch input placeholder no longer suggests master branch Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants