Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect path component of JupyterHub url #172

Merged
merged 1 commit into from Apr 23, 2021
Merged

Respect path component of JupyterHub url #172

merged 1 commit into from Apr 23, 2021

Conversation

yuvipanda
Copy link
Contributor

Fixes #152

@yuvipanda yuvipanda mentioned this pull request Apr 23, 2021
Closed
consideRatio
consideRatio approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me! Let's go for a merge!

@consideRatio consideRatio merged commit ac44f28 into jupyterhub:master Apr 23, 2021
@ttimbers ttimbers mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio approved these changes

@choldgraf choldgraf Awaiting requested review from choldgraf

@GeorgianaElena GeorgianaElena Awaiting requested review from GeorgianaElena

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nbgitpuller link generator not working for Launch from Canvas
2 participants
@yuvipanda @consideRatio