Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse ssh git URLs properly #163

Merged
merged 2 commits into from Dec 17, 2020
Merged

Parse ssh git URLs properly #163

merged 2 commits into from Dec 17, 2020

Conversation

yuvipanda
Copy link
Contributor

Fixes #101

@yuvipanda yuvipanda mentioned this pull request Dec 17, 2020
Closed
GeorgianaElena
GeorgianaElena approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
(I left a couple of comments, but they're mostly questions.)

@GeorgianaElena
Copy link
Member

Thanks @yuvipanda 🚀

@yuvipanda @consideRatio
Mention that binder doesn't work with ssh urls
a9c119a 
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@consideRatio consideRatio merged commit 82a3352 into jupyterhub:master Dec 17, 2020
@consideRatio
Copy link
Member

🥳🥳🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consideRatio consideRatio consideRatio left review comments

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

@ryanlovett ryanlovett Awaiting requested review from ryanlovett

@manics manics Awaiting requested review from manics

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link generator cannot parse ssh repo urls
3 participants
@yuvipanda @GeorgianaElena @consideRatio